Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1708 by Completing the work In Fw #3173

Open
wants to merge 10 commits into
base: devel
Choose a base branch
from

Conversation

LeStarch
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

This completes the work for #1708 by updating Fw.

Fw/Comp/ActiveComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Comp/PassiveComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Comp/PassiveComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Comp/QueuedComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one comment. CI seems unhappy though

Fw/Types/snprintf_format.cpp Outdated Show resolved Hide resolved
Fw/Comp/ActiveComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Comp/PassiveComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Comp/QueuedComponentBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/InputPortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/InputSerializePort.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/PolyType.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/Assert.cpp Fixed Show fixed Hide fixed
Fw/Types/Assert.cpp Fixed Show fixed Hide fixed
Fw/Types/PolyType.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/PolyType.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/PolyType.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/PolyType.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/StringBase.cpp Dismissed Show dismissed Hide dismissed
Fw/Types/StringBase.cpp Dismissed Show dismissed Hide dismissed
cmake/valid-empty.cpp Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@timcanham timcanham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the changes by @LeStarch. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants